Fix: BatchLogProcessor to invoke shutdown on exporter #2696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2696 +/- ##
=====================================
Coverage 79.2% 79.2%
=====================================
Files 123 123
Lines 22572 22582 +10
=====================================
+ Hits 17885 17899 +14
+ Misses 4687 4683 -4 ☔ View full report in Codecov by Sentry. |
lalitb
approved these changes
Feb 21, 2025
Member
lalitb
left a comment
lalitb
left a comment
There was a problem hiding this comment.
LGTM. Do we need to check for async code too ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This area still requires more testing coverage and possibly better error logging. But this is a start!